Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44860: Make sysconfig posix_user not depend on platlibdir #27655

Merged
merged 1 commit into from Sep 7, 2021
Merged

bpo-44860: Make sysconfig posix_user not depend on platlibdir #27655

merged 1 commit into from Sep 7, 2021

Conversation

@uranusjr
Copy link
Contributor

@uranusjr uranusjr commented Aug 7, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44860
@uranusjr uranusjr force-pushed the distutils-unix-user-platlib-match-sysconfig branch from 94fd056 to cc9efb1 Aug 10, 2021
@uranusjr uranusjr changed the title bpo-44860: Match distutils's unix_user platlib to sysconfig Make sysconfig posix_user not depend on platlibdir Aug 10, 2021
@uranusjr uranusjr changed the title Make sysconfig posix_user not depend on platlibdir bpo-44860: Make sysconfig posix_user not depend on platlibdir Aug 10, 2021
merwok
merwok approved these changes Aug 10, 2021
View changes
@pradyunsg pradyunsg mentioned this pull request Aug 13, 2021
Merged
@encukou encukou merged commit a5c6bcf into python:main Sep 7, 2021
13 checks passed
@uranusjr uranusjr deleted the distutils-unix-user-platlib-match-sysconfig branch Sep 7, 2021
@uranusjr
Copy link
Contributor Author

@uranusjr uranusjr commented Sep 7, 2021

I think this needs to be backported to 3.10 (and 3.9?)

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 7, 2021

Thanks @uranusjr for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 7, 2021

GH-28197 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Sep 7, 2021
@uranusjr @miss-islington
Make sysconfig posix_user not depend on platlibdir (pythonGH-27655)
96f9734 
(cherry picked from commit a5c6bcf)

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 7, 2021

@ambv Check if you want to backport this to 3.9 (see the issue)

pablogsal pushed a commit that referenced this issue Sep 7, 2021
@uranusjr @miss-islington
bpo-44860: Make sysconfig posix_user not depend on platlibdir (GH-27655…
608a629 
…) (GH-28197)

(cherry picked from commit a5c6bcf)

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@encukou
Copy link
Member

@encukou encukou commented Sep 7, 2021

I wouldn't backport to 3.9. Changing install locations in a point release could be messy.
pip is using sysconfig in 3.10+ only, where distutils is deprecated. I expect any other tools to do the same.

@ambv ambv mentioned this pull request Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
7 participants
@uranusjr @miss-islington @bedevere-bot @pablogsal @encukou @merwok @the-knights-who-say-ni