Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46329: Change calling sequence (again) #31373

Merged
merged 7 commits into from Feb 18, 2022
Merged

bpo-46329: Change calling sequence (again) #31373

merged 7 commits into from Feb 18, 2022

Conversation

@markshannon
Copy link
Contributor

@markshannon markshannon commented Feb 16, 2022 •
edited by bedevere-bot

  • Add PUSH_NULL instruction.
  • Merge PRECALL_FUNCTION and PRECALL_METHOD into PRECALL.

Changes the current calling sequence:

call_sequence

to this:

call_sequence_with_null

See faster-cpython/ideas#267 (comment) for motivation and analysis.

https://bugs.python.org/issue46329
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 17, 2022

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 2160311 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@markshannon markshannon reopened this Feb 18, 2022
@markshannon markshannon mentioned this pull request Feb 16, 2022
Open
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 18, 2022

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 62e38ec 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@markshannon
Copy link
Contributor Author

@markshannon markshannon commented Feb 18, 2022

The 2 buildbots failures are asyncio being flaky on Mac. Not related to this PR.

@markshannon markshannon merged commit cf345e9 into python:main Feb 18, 2022
83 of 85 checks passed
@markshannon markshannon deleted the add-push-null branch Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
3 participants
@markshannon @bedevere-bot @the-knights-who-say-ni