chore: update siteUrs from netlify.com -> netlify.app #23808
Merged
+89
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update with changes from gatsby
Netlify recently changed their static site links from .com to .app. While this link about the URL changes (https://community.netlify.com/t/changes-coming-to-netlify-site-urls/8918) says that the old .com links will redirect to .app it seems to be causing CORS issues in the demo app
|
I ran the lint command locally but am not sure why there were additional formatting changes aside from my changes from .com to .app |
wardpeet
requested changes
May 6, 2020
Awesome! Thank you for making these changes! Any chance you could search for these URLs in the whole codebase and change all of them? ^^
starters/README.md
Outdated
| @@ -62,7 +62,7 @@ A starter is a simplified example to get up and running with Gatsby quickly and | |||
|
|
|||
| | Name | Demo | Description | | |||
| | :-------------------------------------------------------------------: | --------------------------------------------------------------------------------------------------- | ------------------------------------------------------------- | | |||
| | [blog](https://github.com/gatsbyjs/gatsby-starter-blog) | [gatsby-starter-blog-demo.netlify.com](https://gatsby-starter-blog-demo.netlify.com/) | A starter for a blog powered by Gatsby and Markdown | | |||
| | [blog](https://github.com/gatsbyjs/gatsby-starter-blog) | [gatsby-starter-blog-demo.netlify.com](https://gatsby-starter-blog-demo.netlify.app/) | A starter for a blog powered by Gatsby and Markdown | | |||
| | [default](https://github.com/gatsbyjs/gatsby-starter-default) | [gatsby-starter-default-demo.netlify.com](https://gatsby-starter-default-demo.netlify.com/) | A simple starter to get up and developing quickly with Gatsby | | |||
There was a problem hiding this comment.
Suggested change
| | [default](https://github.com/gatsbyjs/gatsby-starter-default) | [gatsby-starter-default-demo.netlify.com](https://gatsby-starter-default-demo.netlify.com/) | A simple starter to get up and developing quickly with Gatsby | | |
| | [default](https://github.com/gatsbyjs/gatsby-starter-default) | [gatsby-starter-default-demo.netlify.app](https://gatsby-starter-default-demo.netlify.app/) | A simple starter to get up and developing quickly with Gatsby | |
There was a problem hiding this comment.
Hi! I updated to update *-demo.netlify.com to *-demo.netlify.app
wardpeet
approved these changes
May 29, 2020
@M0nica Gatsby has updated the Prettier version it is using to 2.x and this version made some changes to its rule of formatting JavaScript code. Upgrading the Prettier installed in your computer should ensure that you're able to format files in a way consistent to the rest of the project. |
axe312ger
added a commit
that referenced
this issue
Jun 23, 2020
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Netlify recently changed their static site links from .com to .app. While this link about the URL changes (https://community.netlify.com/t/changes-coming-to-netlify-site-urls/8918) says that the old .com links will redirect to .app it seems to be causing CORS issues in the demo app
The demo app seems to work as expected at: https://gatsby-starter-blog-demo.netlify.app/new-beginnings/ whereas https://gatsby-starter-blog-demo.netlify.com/new-beginnings/ when navigated to from https://gatsby-starter-blog-demo.netlify.com throws the errors seen in the above screenshot.
The demo link on GitHub in this template's description should also be updated to point to .app instead of .com by whoever has edit access to this repo's URL box at: https://github.com/gatsbyjs/gatsby-starter-blog
Documentation
https://community.netlify.com/t/changes-coming-to-netlify-site-urls/8918