Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Model generator improvements and more tests #8451

Merged
merged 11 commits into from Mar 23, 2022
Merged

C#: Model generator improvements and more tests #8451

merged 11 commits into from Mar 23, 2022

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Mar 15, 2022 •
edited

In this PR we

  • Improve the model generation for callables that uses collection like types for parameters (or just types that has collection like types as base class)
  • Improve the model generation for callables that uses IEnumerable types as parameter types
  • Introduce more test cases.

@github-actions github-actions bot added the C# label Mar 15, 2022
@michaelnebel michaelnebel marked this pull request as ready for review Mar 16, 2022
@michaelnebel michaelnebel requested a review from as a code owner Mar 16, 2022
@michaelnebel michaelnebel added the no-change-note-required label Mar 16, 2022
@michaelnebel michaelnebel requested a review from hvitved Mar 21, 2022
@michaelnebel michaelnebel requested a review from hvitved Mar 23, 2022
@michaelnebel michaelnebel merged commit 6804e20 into github:main Mar 23, 2022
20 checks passed
@michaelnebel michaelnebel deleted the csharp/modelgenerator-improvements branch Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamasvajk tamasvajk

@hvitved hvitved

Assignees
No one assigned
Labels
C# no-change-note-required
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelnebel @hvitved @tamasvajk