JS/Ruby/Python: rename RegExpTreeView.qll to ReDoSUtilSpecific.qll#8532
Merged
aibaars merged 2 commits intogithub:mainfrom Mar 30, 2022
Merged
JS/Ruby/Python: rename RegExpTreeView.qll to ReDoSUtilSpecific.qll#8532aibaars merged 2 commits intogithub:mainfrom
aibaars merged 2 commits intogithub:mainfrom
Conversation
a74124b to
93c0b59
Compare
93c0b59 to
bd3b21e
Compare
bd3b21e to
b103679
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8489 (review) @nickrolfe pointed out that
There are two files named
RegExpTreeView.qllin the Python and Ruby libraries. One of them contains language specific implementations of classes/predicates needed the the sharedReDoSUtil.qllmodule. As a result they cannot be merged, however, renaming that module toReDoSUtilSpecific.qllavoids the name clash and also makes it clear that the module is just "implementation details".