Update tsc to 4.5.5

[aeisenberg]

The default version of tsc in vscode is now 4.5.4. This version
has changed the type of the variable in the catch block.
Previously, it was any. Now it is unknown.

This change updates vscode so that it can build with 4.5.4.

Previously, this had been a bit of a pain since sometimes running
a compile task in vscode will use the global default version of
tsc.

This is also a chance to try out the new dependency review workflow.

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[cklin]

Do we want to give priority to err.stderr here as well?

[aeisenberg]

I think that was an error. There is no stderr property on the Error class.

[cklin]

There were other places in this file where err.stderr || err is translated to
(err as any).stderr || getErrorMessage(err). Is the difference due to the catch blocks catching different objects? If so, it might be useful to document how we can tell which expression to use where, for the next person who needs to modify this file.

[aeisenberg]

That's interesting. I am really struggling to find out why err.stderr is being used, or if that property even exists.

I suspect that it is coming from here:

vscode-codeql/extensions/ql-vscode/src/cli.ts

Line 1048 in cf99c5e

const result = await promisify(child_process.execFile)(codeQlPath, args);

await promisify(child_process.execFile)(...);

returns an object with { stderr, stdout }. It may be that when catching the error from a child process, the stderr property is being read (even though that's a mistake and it doesn't exist). The other locations in the code could just be copies of the first.

[cklin]

I think you have a better handle on what is happening here than I do, so I will let you do what you think is best.