Fix invalid file comparison for changing ast viewer location#1230
Merged
aeisenberg merged 2 commits intomainfrom Mar 25, 2022
Merged
Fix invalid file comparison for changing ast viewer location#1230aeisenberg merged 2 commits intomainfrom
aeisenberg merged 2 commits intomainfrom
Conversation
This fixes a bug where the ast viewer was not updating its source location when a user clicks on different parts of a file. The problem was that the file name of the AST viewer was being stored as a base name, which was getting compared with the full URI string of the current file. This fixes the comparison to ensure that the full URI strings are always being compared.
shati-patel
approved these changes
Mar 25, 2022
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Thanks! This looks sensible (and works for me locally) 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the ast viewer was not updating its source
location when a user clicks on different parts of a file.
The problem was that the file name of the AST viewer was being stored as
a base name, which was getting compared with the full URI string of the
current file.
This fixes the comparison to ensure that the full URI strings are always
being compared.
Fixes #1224.
Checklist
ready-for-doc-reviewlabel there.