Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-issue: Add assertion to PyModule_GetName for understanding #32236

Merged
merged 2 commits into from Apr 2, 2022
Merged

no-issue: Add assertion to PyModule_GetName for understanding #32236

merged 2 commits into from Apr 2, 2022

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Apr 1, 2022

No description provided.

@corona10 corona10 requested a review from vstinner Apr 1, 2022
vstinner
vstinner reviewed Apr 1, 2022
View changes
Objects/moduleobject.c Outdated Show resolved Hide resolved
@corona10 corona10 changed the title no-issue: Update PyModule_GetName to be more safer no-issue: Add assertion for PyModule_GetName for understanding Apr 2, 2022
@corona10 corona10 changed the title no-issue: Add assertion for PyModule_GetName for understanding no-issue: Add assertion to PyModule_GetName for understanding Apr 2, 2022
@corona10
Copy link
Member Author

@corona10 corona10 commented Apr 2, 2022

lgtm

Merge with LGTM from DM

@corona10 corona10 merged commit b183f48 into python:main Apr 2, 2022
11 checks passed
@corona10 corona10 deleted the PyModule_GetName-safer branch Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot