build: remove remaining travis leftovers #27979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Jan 8, 2019
•
- There still seem to be a few TravisCI leftovers which can be removed now.
- Also fixes that a few e2e tests aren't running. These have been disabled a long time ago, but can be re-enabled now.
|
You can preview 5f4ef73 at https://pr27979-5f4ef73.ngbuilds.io/. |
4d73686
to
f4d4e7b
Compare
|
You can preview f4d4e7b at https://pr27979-f4d4e7b.ngbuilds.io/. |
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.
f4d4e7b
to
f335215
Compare
|
You can preview f335215 at https://pr27979-f335215.ngbuilds.io/. |
gkalpak
approved these changes
Jan 8, 2019
|
caretaker note: pending review check is invalid because the PR has global approver approval @ocombe this is a good example of when robot should not complain about pending reviews. |
|
I removed the merge-assistance label as the bot is now able to ignore team review requests. |
AndrewKushnir
pushed a commit
that referenced
this issue
Jan 9, 2019
AndrewKushnir
pushed a commit
that referenced
this issue
Jan 9, 2019
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them. PR Close #27979
AndrewKushnir
pushed a commit
that referenced
this issue
Jan 9, 2019
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them. PR Close #27979
AndrewKushnir
pushed a commit
that referenced
this issue
Jan 16, 2019
AndrewKushnir
pushed a commit
that referenced
this issue
Jan 16, 2019
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them. PR Close #27979
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this issue
Jan 28, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this issue
Jan 28, 2019
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them. PR Close angular#27979
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.