gh-87212: argparse: capturing actions #24357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added set of 4 new action classes to argparse for capturing preceding arguments. Docs and tests updated.
Fixed whitespaces in tests
Updated ArgumentParser.add_argument signature in documentation
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
approved these changes
Apr 1, 2022
Contributor
MaxwellDupre
left a comment
There was a problem hiding this comment.
Ran 1728 tests in 3.090s
OK
Looks good.
|
This is, IMO, way too big of an addition for the default argparse module. It may be useful for the author and similar users, but I think it would be confusing to almost anyone else. It confused me, and I'm quite knowledgeable about the module. I recommend publishing it on its own on PYPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add set of 4 new action classes to argparse for capturing preceding arguments.