bpo-45099: Document asyncio internal API #32166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Apr 1, 2022
| A third party task implementation should call the following functions to keep a task | ||
| visible by :func:`asyncio.get_tasks` and :func:`asyncio.current_task`: | ||
|
|
||
| .. function:: _register_task(task) |
There was a problem hiding this comment.
I'm not sure these should be documented like this. If we want to document them, we should consider removing the underscore.
|
@asvetlov This at the very least requires an editing pass. And we have reviews by other core devs for a reason, please don't commit things without reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue45099