bpo-47120: make POP_JUMP_IF_NONE/NOT_NONE relative

[iritkatriel]

https://bugs.python.org/issue47120

[iritkatriel]

The case of POP_JUMP_IF_TRUE/IF_FALSE is more complicated because of the COMPARE_OP specialisations. I suggest we do it separately (my current patch doesn't work unless I turn off specialization, debugging).

[markshannon]

The FORWARD jumps don't need to include CHECK_EVAL_BREAKER(), so I think you'll need to implement each instruction independently and not use JUMP_TO_INSTRUCTION.

[markshannon]

Which means the forwards jumps can be made simpler

TARGET(POP_JUMP_FORWARD_IF_NOT_NONE) {
    PyObject *value = POP();
    if (value != Py_None) {
        JUMPBY(oparg);
    }
    Py_DECREF(value);
    DISPATCH();
}

[iritkatriel]

The case of POP_JUMP_IF_TRUE/IF_FALSE is more complicated because of the COMPARE_OP specialisations. I suggest we do it separately (my current patch doesn't work unless I turn off specialization, debugging).

I fixed it now, it was the usual +-1 business. I'll make a separate PR for that, it will be easier to review that way. We can merge magic number later.

[markshannon]

👍

[iritkatriel]

This will be merged as part of #32400