Fix awkward sentence in signal docs #91508
Merged
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
reviewed
Apr 14, 2022
Doc/library/signal.rst
Outdated
| order to avoid :exc:`BrokenPipeError`. Doing that would also | ||
| cause your program to exit unexpectedly whenever any socket |
There was a problem hiding this comment.
Suggested change
| order to avoid :exc:`BrokenPipeError`. Doing that would also | |
| cause your program to exit unexpectedly whenever any socket | |
| order to avoid :exc:`BrokenPipeError`. Doing that causes | |
| your program to exit unexpectedly whenever any socket |
More concise wording
There was a problem hiding this comment.
Ack, sorry for the delayed response. This doesn't quite feel right since I feel like this should be in the future tense? Maybe just remove "also", though I don't care that much and don't want to kill a bunch of time bikeshedding.
There was a problem hiding this comment.
Sure, let's change it back to "would cause" and then I'll merge it
JelleZijlstra
reviewed
Apr 19, 2022
JelleZijlstra
approved these changes
Apr 19, 2022
|
Thanks @strugee for the PR, and @JelleZijlstra for merging it |
|
GH-91716 is a backport of this pull request to the 3.10 branch. |
|
GH-91717 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Apr 20, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 326ae71) Co-authored-by: AJ Jordan <alex@strugee.net>
miss-islington
added a commit
that referenced
this issue
Apr 20, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 326ae71) Co-authored-by: AJ Jordan <alex@strugee.net>
miss-islington
added a commit
that referenced
this issue
Apr 20, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 326ae71) Co-authored-by: AJ Jordan <alex@strugee.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The diff is kind of hard to read because I reformatted where the paragraph breaks, but all I did was move the position of
alsoin the sentence.