Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46712: share more global strings in deepfreeze #32152

Merged
merged 3 commits into from Apr 19, 2022
Merged

bpo-46712: share more global strings in deepfreeze #32152

merged 3 commits into from Apr 19, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Mar 28, 2022 •
edited by ericsnowcurrently

https://bugs.python.org/issue46712

(#90868)

@kumaraditya303 ➜ /workspaces/cpython (more-strings) $ cat Python/deepfreeze/deepfreeze.c | grep _Py_STR | wc -l
159

gvanrossum
gvanrossum reviewed Mar 28, 2022
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

deepfreeze.py changes are okay, but I need @ericsnowcurrently to review the rest.

@gvanrossum gvanrossum requested review from ericsnowcurrently and removed request for markshannon Mar 28, 2022
@kumaraditya303
Copy link
Contributor Author

@kumaraditya303 kumaraditya303 commented Apr 14, 2022

@gvanrossum Any update on this? Is this in Eric's review queue?

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Apr 14, 2022

@ericsnowcurrently Please review.

ericsnowcurrently
ericsnowcurrently approved these changes Apr 19, 2022
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM

@ericsnowcurrently ericsnowcurrently merged commit ab0d35d into python:main Apr 19, 2022
12 checks passed
@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Apr 19, 2022

Thanks, @kumaraditya303! Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kumaraditya303 @gvanrossum @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot