Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90568: Fix error type when parse \N with a named sequence in RE #91665

Merged
merged 1 commit into from Apr 22, 2022
Merged

gh-90568: Fix error type when parse \N with a named sequence in RE #91665

merged 1 commit into from Apr 22, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 18, 2022 •
edited

re.error is now raised instead of TypeError.

Closes #90568.

@serhiy-storchaka serhiy-storchaka merged commit 6ccfa31 into python:main Apr 22, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 22, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the re-parse-named-seq branch Apr 22, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Apr 22, 2022

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6ccfa31421393910b52936e0447625db06f2a655 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Apr 22, 2022

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6ccfa31421393910b52936e0447625db06f2a655 3.9

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 22, 2022
@serhiy-storchaka
[3.10] pythongh-90568: Fix exception type for \N with a named sequenc…
811dc5b 
…e in RE (pythonGH-91665)

re.error is now raised instead of TypeError..
(cherry picked from commit 6ccfa31)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 22, 2022

GH-91830 is a backport of this pull request to the 3.10 branch.

serhiy-storchaka added a commit that referenced this pull request Apr 22, 2022
@serhiy-storchaka
[3.10] gh-90568: Fix exception type for \N with a named sequence in RE (
9c18d78 
GH-91665) (GH-91830)

re.error is now raised instead of TypeError.
(cherry picked from commit 6ccfa31)
serhiy-storchaka added a commit that referenced this pull request Apr 22, 2022
@miss-islington @serhiy-storchaka
[3.9] gh-90568: Fix exception type for \N with a named sequence in RE (…
97d14e1 
…GH-91665) (GH-91830) (GH-91834)

re.error is now raised instead of TypeError.
(cherry picked from commit 6ccfa31)
(cherry picked from commit 9c18d78)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Apr 25, 2022
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @serhiy-storchaka @hello-adam
[3.9] pythongh-90568: Fix exception type for \N with a named sequence…
328ea84 
… in RE (pythonGH-91665) (pythonGH-91830) (pythonGH-91834)

re.error is now raised instead of TypeError.
(cherry picked from commit 6ccfa31)
(cherry picked from commit 9c18d78)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
expert-regex type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError when parsing regexp with unicode named character sequence escape
3 participants
@serhiy-storchaka @miss-islington @bedevere-bot