Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-91547: Remove "Undocumented modules" page #91682

Merged
merged 2 commits into from Apr 22, 2022

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Apr 19, 2022

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 19, 2022
@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented Apr 19, 2022

cc @JelleZijlstra

@arhadthedev
Copy link
Contributor

arhadthedev commented Apr 19, 2022

You can add:

Closes gh-91547.

into the first message of this PR so GitHub will autoclose the issue on merge.

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Apr 19, 2022

I think this is worth documenting in NEWS, since we're removing a whole page. I'll also ask for feedback from the docs WG.

@JelleZijlstra JelleZijlstra self-assigned this Apr 19, 2022
@Mariatta
Copy link
Sponsor Member

Mariatta commented Apr 19, 2022

Yes there is a Documentation section for the news. I think it makes sense to remove this page. The info is already captured in os.path documentation.

@JelleZijlstra JelleZijlstra merged commit 254aaa7 into python:main Apr 22, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 22, 2022

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Apr 22, 2022

GH-91842 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented Apr 22, 2022

GH-91843 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2022
(cherry picked from commit 254aaa7)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Apr 22, 2022
(cherry picked from commit 254aaa7)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Apr 22, 2022
(cherry picked from commit 254aaa7)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@hauntsaninja hauntsaninja deleted the undoc branch Apr 26, 2022
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
(cherry picked from commit 254aaa7)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants