bpo-45451: Remove IDLE shell sidebar padding #32363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed there was a white bar to the left in my IDLE, it stuck out like a soar thumb since I have a custom dark theme. This was not an issue with earlier versions. Changing this line of code solves this issue and leaves the color choices up to the user.
This comment was marked as outdated.
This comment was marked as outdated.
|
Commit authors are required to sign the Contributor License Agreement. |
terryjreedy
requested changes
Apr 11, 2022
This only affects the shell sidebar, which is the subject of bpo-45451. I made the change I requested.
On my Windows with dark theme, I prefer the change. But change needs evaluation on light and dark themes on all 3 major OSes. Will ask OP of issue for opinion. So not approved yet.
terryjreedy
approved these changes
Apr 11, 2022
|
@ambv This should be linked to the new GH issue when available. I overwrote the proposed change and will add blurb before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I noticed there was a white bar to the left in my IDLE, it stuck out like a soar thumb since I have a custom dark theme. This was not an issue with earlier versions.
Changing this line of code solves this issue and leaves the color choices up to the user.
There's some jargon about pull requests that's supposed to go here but I don't think that's necessary since it's such a miniscule issue/change