Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ngram algorithm #6074

Merged
merged 13 commits into from Apr 4, 2022
Merged

feat: added ngram algorithm #6074

merged 13 commits into from Apr 4, 2022

Conversation

9harshit
Copy link
Contributor

@9harshit 9harshit commented Mar 29, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews tests are failing labels Mar 29, 2022
@9harshit
Copy link
Contributor Author

@9harshit 9harshit commented Mar 29, 2022

I don't know why other programs test cases are failing. I haven't changed anything, only added my code.
I suspect black hook fail in precommit is causing this.

Please check the issue @dhruvmanila @cclauss

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Mar 30, 2022

Please rebase on the latest master.

  1. git checkout master
  2. git pull <remote> master
  3. git rebase master <local branch name>

cclauss
cclauss previously requested changes Mar 30, 2022
strings/ngram.py Outdated Show resolved Hide resolved
arithmetic_analysis/in_static_equilibrium.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added awaiting changes and removed awaiting reviews labels Mar 30, 2022
@algorithms-keeper algorithms-keeper bot added awaiting reviews and removed awaiting changes labels Mar 30, 2022
strings/ngram.py Outdated Show resolved Hide resolved
strings/ngram.py Show resolved Hide resolved
9harshit and others added 2 commits Mar 30, 2022
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
strings/ngram.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot removed the tests are failing label Apr 4, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews label Apr 4, 2022
@dhruvmanila dhruvmanila dismissed cclauss’s stale review Apr 4, 2022

Changes have been made.

@dhruvmanila dhruvmanila merged commit 1f1daaf into TheAlgorithms:master Apr 4, 2022
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants