Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92063: Enforce types in specialized PRECALL opcodes #92068

Merged
merged 8 commits into from Apr 30, 2022
Merged

gh-92063: Enforce types in specialized PRECALL opcodes #92068

merged 8 commits into from Apr 30, 2022
+56 −16

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Apr 30, 2022

@sweeneyde sweeneyde requested a review from Fidget-Spinner Apr 30, 2022
@sweeneyde sweeneyde added the 🔨 test-with-buildbots label Apr 30, 2022
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 30, 2022
@sweeneyde sweeneyde changed the title gh-92063: Check the types of PRECALL_METHOD_DESCRIPTOR_FAST_WITH_KEYWORDS gh-92063: Enforce types in specialized PRECALL opcodes Apr 30, 2022
@sweeneyde sweeneyde added the 🔨 test-with-buildbots label Apr 30, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 30, 2022

🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit adb1504 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 30, 2022
@sweeneyde
Copy link
Author

@sweeneyde sweeneyde commented Apr 30, 2022

The single failing buildbot fails on repeated invocations of test_embed.test_finalize_structseq, which is related to #92031

@markshannon
Copy link

@markshannon markshannon commented Apr 30, 2022

@sweeneyde Thanks for fixing this.
Looks good to me.

@markshannon markshannon merged commit 868b1af into python:main Apr 30, 2022
83 of 85 checks passed
@sweeneyde sweeneyde deleted the check_types branch Apr 30, 2022
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue May 1, 2022
@sweeneyde @gvanrossum
pythongh-92063: Enforce types in specialized PRECALL opcodes (pythonG…
acf36d5 
…H-92068)

* Check the types of PRECALL_METHOD_DESCRIPTOR_FAST_WITH_KEYWORDS

* fix PRECALL_NO_KW_METHOD_DESCRIPTOR_NOARGS as well

* fix PRECALL_NO_KW_METHOD_DESCRIPTOR_O

* fix PRECALL_NO_KW_METHOD_DESCRIPTOR_FAST
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue May 1, 2022
@sweeneyde @gvanrossum
pythongh-92063: Enforce types in specialized PRECALL opcodes (pythonG…
26b2f3f 
…H-92068)

* Check the types of PRECALL_METHOD_DESCRIPTOR_FAST_WITH_KEYWORDS

* fix PRECALL_NO_KW_METHOD_DESCRIPTOR_NOARGS as well

* fix PRECALL_NO_KW_METHOD_DESCRIPTOR_O

* fix PRECALL_NO_KW_METHOD_DESCRIPTOR_FAST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

@Fidget-Spinner Fidget-Spinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sweeneyde @bedevere-bot @markshannon