Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) #32256

Open
wants to merge 2 commits into
base: 3.9
Choose a base branch
from

Conversation

Copy link

@mareksuscak mareksuscak commented Apr 2, 2022

This is technically not a backport of the referenced PR because the original PR was superseded by another one and as such was not accepted. I was asked to base this change on the original one because the one that superseded it and was implemented in Python 3.10 was larger in scope and technically considered a breaking change.

This PR fixes bpo-34480. I'm adding two unit tests, one of which is based on a test case included in one of the comments and I want to give full credit for writing it to the original author Karthikeyan Singaravelan (xtreak).

https://bugs.python.org/issue34480

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Apr 2, 2022

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@mareksuscak

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@mareksuscak mareksuscak changed the title [3.9] fix bug where match variable is used prior to being defined (GH-17643) [3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) Apr 2, 2022
@mareksuscak
Copy link
Author

@mareksuscak mareksuscak commented Apr 2, 2022

CLA is now signed. Can take up to 1 business day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants