Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36329: Remove 'make -C Doc serve' in favour of 'make -C Doc htmlview' #32354

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

bpo-36329: Remove 'make -C Doc serve' in favour of 'make -C Doc htmlview' #32354

wants to merge 4 commits into from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 6, 2022 •
edited

Matching Devguide PR: python/devguide#826.

Also updated make -C htmlview so it used a full path with file://, because the original didn't open the page (macOS).

For example:

cd Doc

# Doesn't open anything:
python3 -c "import webbrowser; webbrowser.open('build/html/index.html')"

# Opens the docs page e.g. file:///Users/hugo/github/cpython/Doc/build/html/index.html :
python3 -c "import os, webbrowser; webbrowser.open('file://' + os.path.realpath('build/html/index.html'))"

https://bugs.python.org/issue36329

@hugovk hugovk force-pushed the 36329-docs-make-htmlview branch from 6576b2e to 38747ae Compare Apr 6, 2022
@hugovk hugovk mentioned this pull request Apr 6, 2022
Open
@hugovk hugovk mentioned this pull request Apr 6, 2022
Open
@encukou
Copy link
Member

@encukou encukou commented Apr 8, 2022 •
edited by bedevere-bot

Could you make serve echo The serve target was removed, use htmlview instead (see [bpo-36329](https://bugs.python.org/issue36329)), to help anyone still using it?
Also, could you keep the example in wsgiref docs? It has a purpose there. (Maybe it could be simplified to focus on serving, better commented, and moved to Doc/, of course. But it shouldn't be removed.)

@hugovk
Copy link
Member Author

@hugovk hugovk commented Apr 8, 2022

Updated! How does this look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hugovk @encukou @the-knights-who-say-ni @bedevere-bot