Skip to content

gh-91217: deprecate xdrlib #92066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2022
Merged

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Apr 30, 2022

Automerge-Triggered-By: GH:brettcannon

@miss-islington
Copy link
Contributor

@brettcannon: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c2b5797 into python:main Apr 30, 2022
@brettcannon brettcannon deleted the deprecate-xdrlib branch November 2, 2022 18:42
@megies
Copy link

megies commented Nov 4, 2022

@brettcannon we have some I/O routine over at obspy that uses xdrlib. Would it be a problem to just copy xdrlib.py into our codebase, which we release under LGPLv3?
I quickly rewrote the functionality we use, but I'd actually feel more comfortable to just copy this file and keep using it given that it has been around a long time and I would trust it far more than a quick rewrite, because I know not everything will be fully tested on the rewrite.

If you're the wrong person to ask.. would you know who to ask?

@brettcannon
Copy link
Member Author

@megies IANAL, but from my understanding if you copy the code and keep the license with it then you're fine as the Python license is GPL-compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants