Update typings for mocha #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharad
approved these changes
Feb 11, 2021
2512d38
to
065bcf1
Compare
|
Concerning that the integration tests are failing here. I'll have to explore why. |
This is includes an update of the lock file to the v2 format. It's a big change, but not much is happening here. I thought it best to keep it separate.
065bcf1
to
4f1b11c
Compare
|
Another review, please. The failing tests uncovered a problem with the way we are registering globals. It hasn't affected anything yet, but it's likely to do so in the future. |
adityasharad
approved these changes
Feb 12, 2021
|
Thanks. But, something's still weird and tests are stil failing. I'll have to inspect more. |
|
Do the downloaded CLI and the test DB need to be registered as globals? |
Updating the typings for mocha uncovered an error in how we were registering global setups and teardowns. When calling `mocha.globalSetup` or `mocha.globalTeardown`, any previously registered globals are overwritten. The workaround is to attach globals directly to the internal options object. This is a requirement because we are now registering globals in multiple files. Unfortunately, the typings for mocha do not permit this and I may need to fix them again.
4f1b11c
to
bbe3156
Compare
|
It was just a bad merge. I missed a few bits. Should be working now. |
aofaof0907
added a commit
to aofaof0907/vscode-codeql
that referenced
this issue
Jul 27, 2021
* Update typings for mocha This is includes an update of the lock file to the v2 format. It's a big change, but not much is happening here. I thought it best to keep it separate. * Fix globalSetup/teardown for mocha Updating the typings for mocha uncovered an error in how we were registering global setups and teardowns. When calling `mocha.globalSetup` or `mocha.globalTeardown`, any previously registered globals are overwritten. The workaround is to attach globals directly to the internal options object. This is a requirement because we are now registering globals in multiple files. Unfortunately, the typings for mocha do not permit this and I may need to fix them again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Internal change. Also, updates the lock file format for compatibility with npm v7.
Also, see the second commit:
Fix globalSetup/teardown for mocha
Updating the typings for mocha uncovered an error in how we were
registering global setups and teardowns.
When calling
mocha.globalSetupormocha.globalTeardown, anypreviously registered globals are overwritten. The workaround
is to attach globals directly to the internal options object.
This is a requirement because we are now registering globals in
multiple files.
Unfortunately, the typings for mocha do not permit this and I may need
to fix them again.
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.