C++: Add support for SAX2XMLReader in the CWE-611 XXE query.#9047
Merged
MathiasVP merged 5 commits intogithub:mainfrom May 10, 2022
Merged
C++: Add support for SAX2XMLReader in the CWE-611 XXE query.#9047MathiasVP merged 5 commits intogithub:mainfrom
MathiasVP merged 5 commits intogithub:mainfrom
Conversation
MathiasVP
reviewed
May 9, 2022
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM other than a small comment. Since this PR involves joining with global value numbers, should we maybe run DCA on it?
Contributor
Author
|
I've started a DCA run. |
Contributor
Author
|
DCA LGTM. The query actually ran a bit faster with this change, I don't know if that's wobble or our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for
SAX2XMLReaderin the CWE-611 XXE query.Change note covered by the one in recent PR #8948.