Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92671: Don't omit parentheses when unparsing empty tuples #92673

Merged
merged 2 commits into from May 16, 2022
Merged

gh-92671: Don't omit parentheses when unparsing empty tuples #92673

merged 2 commits into from May 16, 2022

Conversation

isidentical
Copy link
Sponsor Member

@isidentical isidentical commented May 11, 2022

No description provided.

@isidentical isidentical requested a review from pablogsal May 11, 2022
pablogsal
pablogsal reviewed May 11, 2022
View changes
Copy link
Member

@pablogsal pablogsal left a comment •
edited

Can you add a news entry? This was visible on beta1 so we need to ensure users know is fixed :)

@isidentical isidentical requested a review from pablogsal May 11, 2022
@isidentical isidentical added the 🤖 automerge PR will be merged once it's been approved and all CI passed label May 11, 2022
@AlexWaygood
Copy link
Member

AlexWaygood commented May 16, 2022

FYI the bot appears to have stalled on this; a core dev will probably have to merge it manually :)

@pablogsal pablogsal merged commit f6fd8aa into python:main May 16, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 16, 2022

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 16, 2022

Sorry @isidentical and @pablogsal, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f6fd8aac13714ce17650eb4a648d5c08f0be53b4 3.11

@miss-islington
Copy link
Contributor

miss-islington commented May 16, 2022

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@pablogsal
Copy link
Member

pablogsal commented May 16, 2022

@isidentical Does this need backport to 3.10?

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2022
@isidentical @miss-islington
pythongh-92671: Don't omit parentheses when unparsing empty tuples (p…
eb9d154 
…ythonGH-92673)

(cherry picked from commit f6fd8aa)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented May 16, 2022

GH-92848 is a backport of this pull request to the 3.11 branch.

@isidentical
Copy link
Sponsor Member Author

isidentical commented May 16, 2022

No, it doesn't seem to be the case (#92671 (comment)).

miss-islington added a commit that referenced this pull request May 16, 2022
@miss-islington @isidentical
gh-92671: Don't omit parentheses when unparsing empty tuples (GH-92673)
52e6596 
(cherry picked from commit f6fd8aa)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@AlexWaygood AlexWaygood mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees

@pablogsal pablogsal

Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@isidentical @AlexWaygood @miss-islington @pablogsal @bedevere-bot @kumaraditya303