Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-80448: argparse: Fix IndexError on store_true action #15656

Merged
merged 6 commits into from Nov 12, 2022
Merged

gh-80448: argparse: Fix IndexError on store_true action #15656

merged 6 commits into from Nov 12, 2022
+7 −2

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Sep 3, 2019 •
edited by bedevere-bot

@shihai1991 shihai1991 changed the title Fix index_error of argparse bpo-36267: Fix index_error of argparse Sep 3, 2019
@shihai1991
Copy link
Member Author

shihai1991 commented Sep 3, 2019

cc @rhettinger

@matrixise matrixise assigned matrixise and unassigned matrixise Sep 13, 2019
@matrixise matrixise requested a review from rhettinger Sep 13, 2019
@rhettinger rhettinger self-assigned this Sep 14, 2019
@shihai1991
Apply suggestions from code review
2ec664b 
update news by Rémi's suggestion.

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
@rhettinger rhettinger removed their assignment Dec 29, 2021
@rhettinger rhettinger closed this May 1, 2022
@rhettinger rhettinger reopened this May 1, 2022
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 1, 2022 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

@paulj3 paulj3 mannequin mentioned this pull request Apr 10, 2022
Closed
hauntsaninja
hauntsaninja approved these changes Oct 28, 2022
View changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Looks good! Had two nits, although the style one can be ignored cc @JelleZijlstra

Lib/argparse.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2019-09-03-15-45-19.bpo-36267.z42Ex7.rst Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra self-requested a review Oct 28, 2022
@JelleZijlstra @hauntsaninja
Apply suggestions from code review
2538fdb 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@JelleZijlstra JelleZijlstra self-assigned this Nov 1, 2022
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Nov 1, 2022

Planning to merge this after CI passes, and backport to the bugfix branches.

@JelleZijlstra JelleZijlstra changed the title bpo-36267: Fix index_error of argparse gh-80448: argparse: Fix IndexError on store_true action Nov 12, 2022
@JelleZijlstra JelleZijlstra merged commit e02cc6d into python:main Nov 12, 2022
15 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 12, 2022

Thanks @shihai1991 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 12, 2022

Sorry @shihai1991 and @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e02cc6d42aee1f0a9ee629f76576eee478224d9d 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2022
@shihai1991 @JelleZijlstra
@hauntsaninja @miss-islington
pythongh-80448: argparse: Fix IndexError on store_true action (python…
46c0ca5 
…GH-15656)

(cherry picked from commit e02cc6d)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 12, 2022

GH-99404 is a backport of this pull request to the 3.10 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Nov 12, 2022

Thanks @shihai1991 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2022
@shihai1991 @JelleZijlstra
@hauntsaninja @miss-islington
pythongh-80448: argparse: Fix IndexError on store_true action (python…
6bb63fc 
…GH-15656)

(cherry picked from commit e02cc6d)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 12, 2022

GH-99405 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Nov 12, 2022
@miss-islington @shihai1991
@JelleZijlstra @hauntsaninja
gh-80448: argparse: Fix IndexError on store_true action (GH-15656)
8d27e62 
(cherry picked from commit e02cc6d)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 12, 2022
@miss-islington @shihai1991
@JelleZijlstra @hauntsaninja
gh-80448: argparse: Fix IndexError on store_true action (GH-15656)
92b531b 
(cherry picked from commit e02cc6d)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

@hauntsaninja hauntsaninja

@remilapeyre remilapeyre

@rhettinger rhettinger

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@shihai1991 @JelleZijlstra @miss-islington @bedevere-bot @hauntsaninja @remilapeyre @matrixise @rhettinger @the-knights-who-say-ni @ezio-melotti