Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45173: Keep configparser deprecations until Python 3.12 #30952

Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 27, 2022

First commit:

Revert #28292 / 1fc41ae to give projects another year to update before removal of configparser deprecations.

Second commit:

Update the deprecation warnings to explicitly call out that they will be removed in Python 3.12, and mention in What's New and a NEWS file.

Re:

https://bugs.python.org/issue45173

@hugovk
Copy link
Member Author

@hugovk hugovk commented Jan 27, 2022

Should this (the second commit specifically) also go into 3.9 and 3.10 for greater visibility?

@vstinner
Copy link
Member

@vstinner vstinner commented Jan 27, 2022

cc @gpshead

@gpshead
Copy link
Member

@gpshead gpshead commented Jan 27, 2022

I think it seems reasonable for the second commit updating the warning message text to be backported to 3.10, but you should really ask the release manager @pablogsal. I wouldn't bother going as far back as 3.9 with that.

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 28, 2022

but you should really ask the release manager @pablogsal. I wouldn't bother going as far back as 3.9 with that.

I am ok backporting the error message to 3.10.

For 3.9 you should check with @ambv

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 2, 2022

@gpshead @pablogsal: I'm the one who asked for the revert, but I would prefer if someone else merges this PR. Do you want to merge it?

@domdfcoding
Copy link
Contributor

@domdfcoding domdfcoding commented Feb 2, 2022

If the intention is to remove these for good in 3.12, it it worth noting that in the docs for readfp? Currently it only says that it's deprecated, but not that it's about to be removed.

gpshead
gpshead approved these changes Feb 2, 2022
@gpshead
Copy link
Member

@gpshead gpshead commented Feb 2, 2022

If the intention is to remove these for good in 3.12, it it worth noting that in the docs for readfp? Currently it only says that it's deprecated, but not that it's about to be removed.

I think this is fine. Keeping version numbers straight everywhere and sticking to them is hard enough. The important thing given we have a plan here is that the raised warnings now mention a version.

@gpshead gpshead merged commit e8659b4 into python:main Feb 2, 2022
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 2, 2022

Thanks @hugovk for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 2, 2022

Sorry @hugovk and @gpshead, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e8659b47dece5a272111c0af5e340c364a9f807b 3.10

@gpshead
Copy link
Member

@gpshead gpshead commented Feb 2, 2022

feel free to assign warning message update backport PRs to me when you've made them.

@hugovk hugovk deleted the issue45173-revert-configparser-deprecations branch Feb 2, 2022
miss-islington pushed a commit that referenced this issue Feb 2, 2022
@vstinner
Copy link
Member

@vstinner vstinner commented Feb 2, 2022

Python 3.10 didn't get a backward, only the doc was updated: ba4d79a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants