Closed
Conversation
lukepistrol
requested changes
Apr 19, 2022
Comment on lines
+49
to
+50
| let mode = SearchModeModel.IgnoreCase // test; need to figure out how to get mode here | ||
| state.search(searchText, mode: mode) |
Member
There was a problem hiding this comment.
Unnecessary let declaration. Use the value directly in the function call.
Member
|
What's the state of this PR? @melodell |
Collaborator
|
What is the status of this PR, it was opened nearly a month ago and I wanted to prevent it from going stale. I will have to close it if we don't hear back within a few days as there hasn't been any activity here for a while. |
Member
|
Closing this PR since there was no response from @melodell since May 1st 2022. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added potential implementation of "Ignoring Case" search for the Find Navigator.
(Currently there is a placeholder for "testing" the feature, since figuring out the correct way to go about it is a larger implementation/design decision that should be discussed)
Related Issue
Checklist
Screenshots