Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR with additional commits is not handled yet. #64

Open
Mariatta opened this issue Feb 21, 2018 · 2 comments
Open

Backport PR with additional commits is not handled yet. #64

Mariatta opened this issue Feb 21, 2018 · 2 comments

Comments

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Feb 21, 2018

In python/cpython#5781 miss-islington made the backport PR, however there was an additional commit by a core dev.

That scenario is not yet handled:

  • it did not report the status check result
  • it did not auto-merge
@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 21, 2018

Please don't auto-merge. Commit message created by GitHub for multi-commit PRs is composed from commit messages of both commits. This is not what expected. But preserving the original commit message can be not correct too. An additional commit can introduce semantic changes which should be reflected in commit message. In any case only core developer can make the decision.

@Mariatta
Copy link
Member Author

@Mariatta Mariatta commented Feb 21, 2018

Ok so it should not auto-merge.
It should still report that status checks are complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.