gh-92859: Doc: add info about logging.debug() calling basicConfig() (GH-93063) #93063
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Doc/library/logging.rst
Outdated
| @@ -242,6 +242,10 @@ is the module's name in the Python package namespace. | |||
| above example). In such circumstances, it is likely that specialized | |||
| :class:`Formatter`\ s would be used with particular :class:`Handler`\ s. | |||
|
|
|||
| If no handler is attached to this logger (or its parents if | |||
There was a problem hiding this comment.
Perhaps change to
If no handler is attached to this logger (or any of its ancestors,
taking into account the relevant :attr:`Logger.propagate` attributes),
the message will be sent ...
There was a problem hiding this comment.
Addressed on d173e5b
Doc/library/logging.rst
Outdated
| @@ -1038,6 +1042,9 @@ functions. | |||
| above example). In such circumstances, it is likely that specialized | |||
| :class:`Formatter`\ s would be used with particular :class:`Handler`\ s. | |||
|
|
|||
| The function will call :func:`basicConfig` if the root logger doesn't have | |||
There was a problem hiding this comment.
Change to
This function (as well as :func:`info`, :func:`warning`, :func:`error` and :func:`critical`) will call ...
There was a problem hiding this comment.
Addressed on d173e5b
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This adds some info about logging.debug() (and other level functions) calling basicConfig() on behalf of the user if logging wasn't configured beforehand.
|
All commit authors signed the Contributor License Agreement. |
I have made the requested changes; please review again
(sorry for the force push, I reset my email on the first commit)
Doc/library/logging.rst
Outdated
| @@ -242,6 +242,10 @@ is the module's name in the Python package namespace. | |||
| above example). In such circumstances, it is likely that specialized | |||
| :class:`Formatter`\ s would be used with particular :class:`Handler`\ s. | |||
|
|
|||
| If no handler is attached to this logger (or its parents if | |||
There was a problem hiding this comment.
Addressed on d173e5b
Doc/library/logging.rst
Outdated
| @@ -1038,6 +1042,9 @@ functions. | |||
| above example). In such circumstances, it is likely that specialized | |||
| :class:`Formatter`\ s would be used with particular :class:`Handler`\ s. | |||
|
|
|||
| The function will call :func:`basicConfig` if the root logger doesn't have | |||
There was a problem hiding this comment.
Addressed on d173e5b
…ig() (pythonGH-93063) (cherry picked from commit 2176898) Co-authored-by: Nicolas Haller <nicolas@haller.im>
|
GH-93150 is a backport of this pull request to the 3.10 branch. |
…ig() (pythonGH-93063) (cherry picked from commit 2176898) Co-authored-by: Nicolas Haller <nicolas@haller.im>
|
GH-93151 is a backport of this pull request to the 3.11 branch. |
This adds some info about logging.debug() (and other level functions)
calling basicConfig() on behalf of the user if logging wasn't configured
beforehand.
#92859