gh-93172: Remove unnecessary if in binascii_a2b_qp_impl() from Modules/binascii.c #93181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It looks like there's a second occurrence of this elsewhere in the file. Would you mind changing that as well in this PR? |
Member
|
NEWS file is not needed for small changes that is invisible to users. |
Author
@sweeneyde Sure!
@methane Apologies. I have deleted the news entry. |
added 2 commits
May 25, 2022 11:35
methane
approved these changes
May 25, 2022
Author
|
Thanks @sweeneyde @methane! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #93172.
Removed an unnecessary
ifinbinascii_a2b_qp_impl()fromModules/binascii.c.