bpo-35066: Make trailing percent test more portable. #15907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
approved these changes
Sep 11, 2019
pganssle
requested changes
Sep 11, 2019
Lib/test/datetimetester.py
Outdated
| @@ -1456,8 +1456,11 @@ def test_strftime_trailing_percent(self): | |||
| _time.strftime('%') | |||
| except ValueError: | |||
| self.skipTest('time module does not support trailing %') | |||
| self.assertEqual(t.strftime('%'), '%') | |||
| self.assertEqual(t.strftime("m:%m d:%d y:%y %"), "m:03 d:02 y:05 %") | |||
| self.assertEqual(t.strftime('%'), _time.strftime('%'), t.timetuple()) | |||
There was a problem hiding this comment.
Suggested change
| self.assertEqual(t.strftime('%'), _time.strftime('%'), t.timetuple()) | |
| self.assertEqual(t.strftime('%'), _time.strftime('%', t.timetuple())) |
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be poked with soft cushions! |
Different libc implementations have different behavior when presented with trailing % in strftime strings. To make test_strftime_trailing_percent more portable, compare the output of datetime.strftime directly to that of time.strftime rather than hardcoding.
|
I have made the requested changes; please review again.
…On Wed, Sep 11, 2019, at 11:25, Bedevere (bot) wrote:
When you're done making the requested changes, leave the comment: `I
have made the requested changes; please review again`.
And if you don't make the requested changes, you will be poked with
soft cushions! <https://youtu.be/XnS49c9KZw8?t=1m7s>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15907?email_source=notifications&email_token=AABVSTTFY4LKKUJYMMZ2JQ3QJDBTNA5CNFSM4IVR2PF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6OAWKI#issuecomment-530320169>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABVSTRREECRETA6NSHPC4LQJDBTNANCNFSM4IVR2PFQ>.
|
|
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
pganssle
approved these changes
Sep 11, 2019
|
Per conversation at the core dev sprint - I'm mildly uncomfortable about changing this because the aspiration is that this behavior should work on all platforms, and we should probably set platform-specific expected failures instead of changing this, but practically speaking, this might break a bunch of platforms while we're not really prepared to actually create a platform-independent version of this, so for now I agree that we should do this more-portable version of the test. |
|
Thanks @benjaminp for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Sep 11, 2019
Different libc implementations have different behavior when presented with trailing % in strftime strings. To make test_strftime_trailing_percent more portable, compare the output of datetime.strftime directly to that of time.strftime rather than hardcoding. (cherry picked from commit f2173ae) Co-authored-by: Benjamin Peterson <benjamin@python.org>
|
GH-15915 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Sep 11, 2019
Different libc implementations have different behavior when presented with trailing % in strftime strings. To make test_strftime_trailing_percent more portable, compare the output of datetime.strftime directly to that of time.strftime rather than hardcoding. (cherry picked from commit f2173ae) Co-authored-by: Benjamin Peterson <benjamin@python.org>
|
GH-15916 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this issue
Sep 11, 2019
Different libc implementations have different behavior when presented with trailing % in strftime strings. To make test_strftime_trailing_percent more portable, compare the output of datetime.strftime directly to that of time.strftime rather than hardcoding. (cherry picked from commit f2173ae) Co-authored-by: Benjamin Peterson <benjamin@python.org>
miss-islington
added a commit
that referenced
this issue
Sep 11, 2019
Different libc implementations have different behavior when presented with trailing % in strftime strings. To make test_strftime_trailing_percent more portable, compare the output of datetime.strftime directly to that of time.strftime rather than hardcoding. (cherry picked from commit f2173ae) Co-authored-by: Benjamin Peterson <benjamin@python.org>
vrpolakatcisco
pushed a commit
to vrpolakatcisco/cpython
that referenced
this issue
Sep 12, 2019
Different libc implementations have different behavior when presented with trailing % in strftime strings. To make test_strftime_trailing_percent more portable, compare the output of datetime.strftime directly to that of time.strftime rather than hardcoding.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this issue
Sep 12, 2019
Different libc implementations have different behavior when presented with trailing % in strftime strings. To make test_strftime_trailing_percent more portable, compare the output of datetime.strftime directly to that of time.strftime rather than hardcoding.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this issue
Jul 20, 2020
Different libc implementations have different behavior when presented with trailing % in strftime strings. To make test_strftime_trailing_percent more portable, compare the output of datetime.strftime directly to that of time.strftime rather than hardcoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Different libc implementations have different behavior when presented with trailing % in strftime strings. To make test_strftime_trailing_percent more portable, compare the output of datetime.strftime directly to that of time.strftime rather than hardcoding.
https://bugs.python.org/issue35066
Automerge-Triggered-By: @pganssle
Automerge-Triggered-By: @pganssle