Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend power iteration to handle complex Hermitian input matrices #5925

Merged
merged 5 commits into from Feb 2, 2022

Conversation

calvinmccarter
Copy link
Contributor

@calvinmccarter calvinmccarter commented Jan 16, 2022

Describe your change:

This PR extends the standard version of the power iteration to handle complex Hermitian input matrices. The only algorithmic change for complex-valued matrices is that the (simplified) Rayleigh Quotient for finding the eigenvalue needs to use the conjugate transpose (x^H M x) rather than the regular transpose (x^T M x).

I also fixed a typo in the documentation ("eignevalue" -> "eigenvalue").

  • Add an algorithm?
  • [] Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

python3 -m unittest discover --start-directory src --pattern "power*.py" --t . -v
@algorithms-keeper algorithms-keeper bot added enhancement awaiting reviews labels Jan 16, 2022
@algorithms-keeper algorithms-keeper bot added the tests are failing label Jan 30, 2022
@calvinmccarter
Copy link
Contributor Author

@calvinmccarter calvinmccarter commented Feb 2, 2022

@cclauss -- I think I fixed the flake8 issue, could you please run the tests again?

@algorithms-keeper algorithms-keeper bot removed the tests are failing label Feb 2, 2022
cclauss
cclauss approved these changes Feb 2, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews label Feb 2, 2022
@cclauss cclauss merged commit 54f765b into TheAlgorithms:master Feb 2, 2022
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants