Method updateTsConfig doesn't validate if the short import is already added

[Hyperxq]

🐞 Bug report

File

Command

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• extract-i18n
• run
• config
• help
• version
• doc

Is this a regression?

No

Description

When you call the method updateTsConfig and you already has this short import in paths.

🔥 Exception or Error

Duplicate Object key

Proposed solution

export function updateTsConfig(packageName: string, ...paths: string[]) {
  return (host: Tree) => {
    if (!host.exists("tsconfig.json")) {
      return host;
    }

    const file = new JSONFile(host, "tsconfig.json");
    const jsonPath = ["compilerOptions", "paths", packageName.toLowerCase()];
    const value: string[] | undefined = file.get(jsonPath) as string[];
    let pathsFiltered: string[] = [];
    if (value) {
      pathsFiltered = paths?.filter((item) => !value!.some((path) => path === item));
    }

    file.modify(jsonPath, Array.isArray(value) ? [...value, ...pathsFiltered] : paths);
  };
}

[alan-agius4]

Can you please elaborate on the use case were you already have path for a library that doesn't exist? Likely if this path is set is not correct anyways so it should be overridden.

[alan-agius4]

Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand the problem. Please check out our submission guidelines to understand why we can't act on issues that are lacking important information.

If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}