Schematics class name validation #23485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g without using a `.` `.` is not a valid character in ES6 class names. Prior to this change `foo.module` before used to be incorrectly classified to `Foo.Module` instead of `FooModule`. Closes angular#13824
d271e42
to
8d8faec
Compare
clydin
requested changes
Jul 1, 2022
| @@ -89,7 +90,7 @@ export function classify(str: string): string { | |||
| return str | |||
| .split('.') | |||
| .map((part) => capitalize(camelize(part))) | |||
| .join('.'); | |||
| .join(''); | |||
There was a problem hiding this comment.
I'm wondering if this would be a breaking change since it is public and it could be expected to operate in the previous manner.
There was a problem hiding this comment.
Umm… not sure show to classify this since technically it is was an incorrect behaviour.
Maybe we should discuss it during our next sync.
With this change we prevent creating classes with invalid characters. Closes angular#12868
8d8faec
to
0fc7b05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fix(@angular-devkit/core):
classifystring util should concat string without using a..is not a valid character in ES6 class names.Prior to this change
foo.modulebefore used to be incorrectly classified toFoo.Moduleinstead ofFooModule.Closes #13824
fix(@schematics/angular): prevent numbers from class names
With this change we prevent creating classes with invalid characters.
Closes #12868
Combined into a single PR as they are dependent on each other.