bpo-12067: Add tests to test_compare

[csabella]

Last part of existing patch that hasn't been committed yet.

Patch by Andy Maier and Martin Panter.

https://bugs.python.org/issue12067

[matrixise]

Hello @csabella

What's the status of this PR?

Have a nice day

[csabella]

Hi @matrixise,

It hasn't been reviewed yet. I don't have any other updates.

[terryjreedy]

Merge conflicts were from test_compare part of #15167. Waiting for retest results.

On issue, Martin Panter said, after committing doc changes, "Someone needs to decide whether to use Andy’s tests as they are, or perhaps modify or drop some or all of them." Cheryl created this PR from the test part of the last .diff file and review is still needed.

[terryjreedy]

Tests that I presume once passed now fail due to improved constant constant folding and identity checking of results. The following now prints True & True in batch mode, whereas the tests below presume the opposite. (In interactive mode, where each line is compiled separately, they print false as matching constants requires that they be compiled together.) I think all the is not tests should be deleted. Only leave 'a is a' test and 'a is not b' where b is bound to a different constant.

test_binary_sequences (test.test_compare.ComparisonFullTest) ... FAIL
test_numbers (test.test_compare.ComparisonFullTest) ... FAIL
test_sequences (test.test_compare.ComparisonFullTest) ... FAIL

======================================================================
FAIL: test_binary_sequences (test.test_compare.ComparisonFullTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_compare.py", line 642, in test_binary_sequences
    self.assertIsNot(bs2, bs3, "Testcase error: bs2 is bs3")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: unexpectedly identical: b'b2' : Testcase error: bs2 is bs3

======================================================================
FAIL: test_numbers (test.test_compare.ComparisonFullTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_compare.py", line 516, in test_numbers
    self.assertIsNot(c2, c3, "Testcase error: c2 is c3")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: unexpectedly identical: (2+2j) : Testcase error: c2 is c3

======================================================================
FAIL: test_sequences (test.test_compare.ComparisonFullTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_compare.py", line 604, in test_sequences
    self.assertIsNot(t2, t3, "Testcase error: t2 is t3")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: unexpectedly identical: (2, 3) : Testcase error: t2 is t3

[github-actions]

This PR is stale because it has been open for 30 days with no activity.

[github-actions]

This PR is stale because it has been open for 30 days with no activity.