Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95355: Check tokens[0] after allocating memory #95356

Merged
merged 4 commits into from Jul 28, 2022
Merged

gh-95355: Check tokens[0] after allocating memory #95356

merged 4 commits into from Jul 28, 2022

Conversation

imzhuhl
Copy link
Contributor

@imzhuhl imzhuhl commented Jul 28, 2022 •
edited by miss-islington

#95355

Automerge-Triggered-By: GH:pablogsal

@cpython-cla-bot
Copy link

@cpython-cla-bot cpython-cla-bot bot commented Jul 28, 2022 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 28, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 28, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@CharlieZhao95
Copy link
Contributor

@CharlieZhao95 CharlieZhao95 commented Jul 28, 2022

Good find.
p->tokens is a 2-dimensional pointer to Token *, p->tokens[0] is a pointer to Token structure.
In my opinion, it does need to be modified.

@imzhuhl @arhadthedev
Update Misc/NEWS.d/next/Core and Builtins/2022-07-28-08-33-31.gh-issu…
58821f2 
…e-95355.yN4XVk.rst

Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 28, 2022

LGTM Good catch!

@pablogsal pablogsal added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jul 28, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 28, 2022

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit b946f52 into python:main Jul 28, 2022
14 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 28, 2022

Thanks @imzhuhl for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 28, 2022

GH-95367 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 28, 2022
@imzhuhl @miss-islington
pythongh-95355: Check tokens[0] after allocating memory (pythonGH-95356)
c2fb6ca 
pythonGH-95355

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit b946f52)

Co-authored-by: Honglin Zhu <zhuhonglin.zhl@alibaba-inc.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 28, 2022
@imzhuhl @miss-islington
pythongh-95355: Check tokens[0] after allocating memory (pythonGH-95356)
8cb867d 
pythonGH-95355

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit b946f52)

Co-authored-by: Honglin Zhu <zhuhonglin.zhl@alibaba-inc.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 28, 2022

GH-95368 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this issue Jul 28, 2022
@miss-islington @imzhuhl
gh-95355: Check tokens[0] after allocating memory (GH-95356)
d3cc99b 
GH-95355

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit b946f52)

Co-authored-by: Honglin Zhu <zhuhonglin.zhl@alibaba-inc.com>
miss-islington added a commit that referenced this issue Jul 28, 2022
@miss-islington @imzhuhl
gh-95355: Check tokens[0] after allocating memory (GH-95356)
4513e4a 
GH-95355

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit b946f52)

Co-authored-by: Honglin Zhu <zhuhonglin.zhl@alibaba-inc.com>
@kumaraditya303 kumaraditya303 mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev

@pablogsal pablogsal

@lysnikolaou lysnikolaou

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@imzhuhl @bedevere-bot @CharlieZhao95 @pablogsal @miss-islington @arhadthedev