refactoring and type fix #24490
Closed
refactoring and type fix #24490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serverwentdown
approved these changes
Feb 11, 2021
serverwentdown
suggested changes
Feb 11, 2021
| @@ -106,7 +106,6 @@ class A: | |||
| wr = None | |||
|
|
|||
| class Foo(unittest.TestCase): | |||
|
|
|||
There was a problem hiding this comment.
Just read the devguide, I think this would be rejected as it is a formatting change.
Also mentioned here is "Do not do cosmetic changes to unrelated code in the same commit as some feature/bugfix".
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
just typo fix and couple of small refactors
skip news
skip issue