Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95173: Add a regression test for sorting tuples containing None #95464

Merged
merged 2 commits into from Aug 1, 2022

Conversation

jacobtylerwalls
Copy link
Contributor

@jacobtylerwalls jacobtylerwalls commented Jul 30, 2022

This PR adds the test case from #95173 to test_sort.py.

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jul 30, 2022
Lib/test/test_sort.py Outdated Show resolved Hide resolved
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 1, 2022

It looks like the PR that fixed the linked issue was reverted (#95220) for the 3.11 branch, so I assume this is not going to be backported to 3.11.

@jacobtylerwalls
Copy link
Contributor Author

jacobtylerwalls commented Aug 1, 2022

Thanks for the review. #95220 (588d0cb) was not reverted. (Possible source of confusion: itself, it was a reversion of #29076 (51ed2c5).

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 1, 2022

Ok. IIUC, the test should be backported to 3.11.

@erlend-aasland erlend-aasland merged commit c0cd790 into python:main Aug 1, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 1, 2022

Thanks @jacobtylerwalls for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2022
…one (pythonGH-95464)

(cherry picked from commit c0cd790)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 1, 2022

GH-95537 is a backport of this pull request to the 3.11 branch.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 1, 2022

Thanks for the PR, Jacob!

@jacobtylerwalls jacobtylerwalls deleted the test-none-in-tuples branch Aug 1, 2022
@bedevere-bot
Copy link

bedevere-bot commented Aug 1, 2022

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit c0cd790.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/2392) and take a look at the build logs.
  4. Check if the failure is related to this commit (c0cd790) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/2392

Failed tests:

  • test_asyncio

Failed subtests:

  • test_create_server_ssl_over_ssl - test.test_asyncio.test_ssl.TestSSL.test_create_server_ssl_over_ssl

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

411 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 33 sec
  • test_multiprocessing_spawn: 2 min 5 sec
  • test_multiprocessing_forkserver: 1 min 42 sec
  • test_logging: 1 min 1 sec
  • test_nntplib: 1 min 1 sec
  • test_signal: 46.6 sec
  • test_ssl: 45.3 sec
  • test_io: 38.7 sec
  • test_tokenize: 37.5 sec
  • test_capi: 33.8 sec

1 test failed:
test_asyncio

21 tests skipped:
test_devpoll test_epoll test_gdb test_idle test_ioctl
test_launcher test_msilib test_multiprocessing_fork
test_ossaudiodev test_spwd test_startfile test_tcl test_tix
test_tkinter test_ttk test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_asyncio

Total duration: 19 min 32 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_asyncio/test_ssl.py", line 1160, in test_create_server_ssl_over_ssl
    self.loop.run_until_complete(start_server())
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/base_events.py", line 650, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_asyncio/test_ssl.py", line 1153, in start_server
    await asyncio.wait_for(asyncio.gather(*tasks), TIMEOUT)
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/tasks.py", line 488, in wait_for
    return fut.result()
           ^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_asyncio/test_ssl.py", line 1131, in test_client
    await fut
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_asyncio/test_ssl.py", line 1109, in prog
    do(sslobj.write, B_DATA)
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_asyncio/test_ssl.py", line 1100, in do
    sock.send(outgoing.read())
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1148, in send
    return self._sslobj.write(data)
           ^^^^^^^^^^^^^^^^^^^^^^^^
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:2390)

miss-islington added a commit that referenced this pull request Aug 1, 2022
…H-95464)

(cherry picked from commit c0cd790)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants