Java: query to detect android:debuggable attribute enabled #9939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf5c2e4 to
9edbac8
Compare
atorralba
reviewed
Aug 2, 2022
java/ql/test/query-tests/security/CWE-489/DebuggableAttributeEnabledTest.ql
Outdated
Show resolved
Hide resolved
java/ql/src/Security/CWE/CWE-489/DebuggableAttributeEnabled.qhelp
Outdated
Show resolved
Hide resolved
17d99ff to
171a47e
Compare
atorralba
reviewed
Aug 3, 2022
Contributor
atorralba
left a comment
There was a problem hiding this comment.
We're getting close! Some more comments:
java/ql/test/query-tests/security/CWE-489/DebuggableAttributeEnabledTest.ql
Outdated
Show resolved
Hide resolved
171a47e to
bee310d
Compare
5df94b1 to
55be4f1
Compare
Contributor
|
Covering for the docs first responder here 👋🏻 - I added this PR to our board for review by the Docs team. Thanks for your patience 🙇🏻♀️ 😅 |
55be4f1 to
40034fa
Compare
mchammer01
previously approved these changes
Aug 15, 2022
Contributor
mchammer01
left a comment
There was a problem hiding this comment.
@jcogs33 👋🏻 - thanks for your patience. This LGTM ✨
I am approving this from an editorial point of view, but would be grateful if you could look at my minor comments. Thank youuu 🙇🏻♀️ 🙂
java/ql/src/Security/CWE/CWE-489/DebuggableAttributeEnabled.qhelp
Outdated
Show resolved
Hide resolved
java/ql/src/Security/CWE/CWE-489/DebuggableAttributeEnabled.qhelp
Outdated
Show resolved
Hide resolved
java/ql/src/Security/CWE/CWE-489/DebuggableAttributeEnabled.qhelp
Outdated
Show resolved
Hide resolved
added 10 commits
August 15, 2022 15:49
added 14 commits
August 15, 2022 15:50
…iew' to references
40034fa to
07e141c
Compare
mchammer01
approved these changes
Aug 16, 2022
Contributor
mchammer01
left a comment
There was a problem hiding this comment.
@jcogs33 - thanks for addressing my comments, this is good to go from an editorial point of view ✨ 
atorralba
approved these changes
Aug 16, 2022
Contributor
atorralba
left a comment
There was a problem hiding this comment.
Looks good to merge! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query warns about
android:debuggable="true"set in the application section of theAndroidManifest.xmlfile.