gh-78143: IDLE - fix settings dialog page label.#96009
Merged
Merged
Conversation
'/Tab' should have been removed from the font page label when the tab-spaces setting was moved to the Windows page.
Member
Author
|
@pablogsal This trivial change fixes the displayed text on a Notebook tab. It should have been included in #22954 when the latter was changed to move the font-space setting to a different page. I plan to commit this tomorrow (Aug 16). |
pablogsal
approved these changes
Aug 15, 2022
Member
pablogsal
left a comment
There was a problem hiding this comment.
Let's get it in. Thanks for checking with me 👍
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 15, 2022
'/Tab' should have been removed from the font page label when the tab-spaces setting was moved to the Windows page. (cherry picked from commit f6b8110) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-96011 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 15, 2022
'/Tab' should have been removed from the font page label when the tab-spaces setting was moved to the Windows page. (cherry picked from commit f6b8110) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-96012 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Aug 15, 2022
miss-islington
added a commit
that referenced
this pull request
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'/Tab' should have been removed from the font page label
when the tab-spaces setting was moved to the Windows page.