Skip to content

Documentation update #95894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Documentation update #95894

wants to merge 3 commits into from

Conversation

arq0017
Copy link

@arq0017 arq0017 commented Aug 11, 2022

code :

dest_folder = "./sourceFolder"
path = shutil.make_archive("testing", "tar", dest_folder)
print(path)

actual output :
/Users/henry/PycharmProjects/pythonProject/testing.tar

code : 
```
dest_folder = "./sourceFolder"
path = shutil.make_archive("testing", "tar", dest_folder)
print(path)
```
actual output : 
/Users/henry/PycharmProjects/pythonProject/testing.tar
@ghost
Copy link

ghost commented Aug 11, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 11, 2022
@arq0017 arq0017 changed the title Returns archive's absolute path rather than name Documentation update Sep 8, 2022
@slateny
Copy link
Contributor

slateny commented Sep 25, 2022

If root_dir isn't specified then the absolute path doesn't appear:

>>> import shutil
>>> path = shutil.make_archive('testing', 'tar')
>>> print(path)
testing.tar

Maybe this could use a note in the root_dir section, but nonetheless the target branch needs to be main and not 3.10 unless it's specifically for a backport, and would need a new PR as it can't be changed.

@slateny slateny closed this Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants