Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-96071: fix deadlock in PyGILState_Ensure #96124

Merged
merged 3 commits into from Aug 19, 2022
Merged

GH-96071: fix deadlock in PyGILState_Ensure #96124

merged 3 commits into from Aug 19, 2022
+17 −11

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Aug 19, 2022 •
edited by miss-islington

Alternative of #96107

Automerge-Triggered-By: GH:ericsnowcurrently

@kumaraditya303 kumaraditya303 requested a review from pablogsal Aug 19, 2022
@pablogsal
Copy link
Member

pablogsal commented Aug 19, 2022

Nice, now that we have both, which one do you prefer in terms of maintainability? (Is ok if you like the other one more)

I personally like this one a bit more because I can reason easier about re-entrancy and concurrency

@kumaraditya303 kumaraditya303 mentioned this pull request Aug 19, 2022
Closed
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Aug 19, 2022

@pablogsal Let's go with this one. I agree this is easier to understand than the other one.

@kumaraditya303 kumaraditya303 added interpreter-core release-blocker needs backport to 3.11 labels Aug 19, 2022
ericsnowcurrently
ericsnowcurrently requested changes Aug 19, 2022
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM (with one minor adjustment to a comment)

Python/pystate.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Aug 19, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@kumaraditya303 @ericsnowcurrently
Update Python/pystate.c
1f75cb4 
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Aug 19, 2022
@miss-islington miss-islington merged commit e0d54a4 into python:main Aug 19, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 19, 2022

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 19, 2022
@kumaraditya303 @miss-islington
pythonGH-96071: fix deadlock in PyGILState_Ensure (pythonGH-96124)
1a1e72f 
Alternative of pythonGH-96107
(cherry picked from commit e0d54a4a799dae4ebdd72a16bcf287ed62ae2972)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 19, 2022

GH-96129 is a backport of this pull request to the 3.11 branch.

pablogsal pushed a commit that referenced this issue Aug 19, 2022
@miss-islington @kumaraditya303
GH-96071: fix deadlock in PyGILState_Ensure (GH-96124) (#96129)
1fa9644 
Alternative of GH-96107
(cherry picked from commit e0d54a4)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303 kumaraditya303 deleted the pystate-2 branch Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently

@pablogsal pablogsal

Assignees
No one assigned
Labels
interpreter-core release-blocker 🤖 automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kumaraditya303 @pablogsal @bedevere-bot @miss-islington @ericsnowcurrently