Skip to content

initialize extension tests#825

Merged
Eskibear merged 3 commits intomainfrom
test
Jun 22, 2022
Merged

initialize extension tests#825
Eskibear merged 3 commits intomainfrom
test

Conversation

@Eskibear
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Copy Markdown
Member Author

A simple case added for the first time. Result as below.

[main 2022-06-21T02:42:16.333Z] update#setState idle

[main 2022-06-21T02:42:17.584Z] Starting extension host with pid 23536 (fork() took 16 ms).

Loading development extension at <redacted>

  Maven Project View Tests

    ✔ Can list maven projects (112ms)

  1 passing (140ms)

[main 2022-06-21T02:42:28.045Z] Waiting for extension host with pid 23536 to exit.

[main 2022-06-21T02:42:28.059Z] Extension host with pid 23536 exited with code: 0, signal: null.

Exit code:   0
Done

@Eskibear Eskibear marked this pull request as ready for review June 21, 2022 02:44
@Eskibear Eskibear requested review from CsCherrYY and jdneo June 21, 2022 02:44
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@CsCherrYY
Copy link
Copy Markdown
Contributor

The test framework vscode-test has been renamed to @vscode/test-electron and the current version (1.5.1) has been outdated for about one year. It makes us

  1. must add something like --disable-workspace-trust in the running argument
  2. are not able to run test with an existing VS Code instance.

and so on. Could you update the test framework to the newest version and see if there is any breaking change?

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Copy Markdown
Member Author

@CsCherrYY Updated. So far so good in my case. The only difference is you have to specify a platform when downloading target vscode packages.

@CsCherrYY
Copy link
Copy Markdown
Contributor

the changes LGTM. How can we trigger the tests in CI? via Github Actions or Azure pipeline?

@Eskibear
Copy link
Copy Markdown
Member Author

I'm thinking of setting up GitHub Actions later.

Copy link
Copy Markdown
Contributor

@CsCherrYY CsCherrYY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eskibear Eskibear merged commit e170dcb into main Jun 22, 2022
@Eskibear Eskibear deleted the test branch June 22, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants