Skip to content

Fix a mistake in isSet() deprecated message doc #95720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Fix a mistake in isSet() deprecated message doc #95720

merged 1 commit into from
Oct 7, 2022

Conversation

marcmonfort
Copy link
Contributor

Fix a mistake in isSet() deprecated message where it recommends to use notify_all() instead of is_set().

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Aug 5, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@marcmonfort marcmonfort changed the title Fix a mistake in isSet() deprecated message Fix a mistake in isSet() deprecated message doc Aug 9, 2022
@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 7, 2022
@JelleZijlstra JelleZijlstra merged commit 7f68568 into python:main Oct 7, 2022
@miss-islington
Copy link
Contributor

Thanks @marcmonfort for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @marcmonfort and @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7f685683f8e23084aa8b05f0c186f5c962f1db29 3.11

@miss-islington
Copy link
Contributor

Sorry, @marcmonfort and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7f685683f8e23084aa8b05f0c186f5c962f1db29 3.10

@JelleZijlstra JelleZijlstra added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 7, 2022
@miss-islington
Copy link
Contributor

Thanks @marcmonfort for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @marcmonfort and @JelleZijlstra, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7f685683f8e23084aa8b05f0c186f5c962f1db29 3.11

@JelleZijlstra
Copy link
Member

This was already fixed in e534440 / #96297, I just merged an empty commit. That's why the backports failed.

@JelleZijlstra JelleZijlstra removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 7, 2022
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants