Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mean absolute error in linear regression #7003

Merged
merged 7 commits into from Oct 30, 2022
Merged

Added mean absolute error in linear regression #7003

merged 7 commits into from Oct 30, 2022

Conversation

KushagraMakharia
Copy link
Contributor

@KushagraMakharia KushagraMakharia commented Oct 11, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files. awaiting reviews This PR is ready to be reviewed. labels Oct 11, 2022
CaedenPH
CaedenPH reviewed Oct 11, 2022
View changes
machine_learning/linear_regression.py Outdated
@@ -87,6 +87,19 @@ def run_linear_regression(data_x, data_y):
return theta


def mean_absolute_error(pred_X, org_X):
Copy link
Contributor

@CaedenPH CaedenPH Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide more descriptive variable names and use snake_case

machine_learning/linear_regression.py Outdated
:param pred_X : contains the output (result vector)
:param org_X : contains our dataset
:return : mean absolute error computed from given feature's
Copy link
Contributor

@CaedenPH CaedenPH Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as parameter names are more descriptive, the names should explain themselves

CaedenPH
CaedenPH reviewed Oct 30, 2022
View changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

@cclauss Looks good - perhaps you commit my changes

machine_learning/linear_regression.py Outdated Show resolved Hide resolved
machine_learning/linear_regression.py Outdated Show resolved Hide resolved
@cclauss @CaedenPH
Apply suggestions from code review
b26c1ca 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@cclauss cclauss merged commit 69d04ff into TheAlgorithms:master Oct 30, 2022
2 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed. label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH

@cclauss cclauss

Assignees
No one assigned
Labels
enhancement This PR modified some existing files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KushagraMakharia @cclauss @CaedenPH