Correct Treap split docstring to reflect actual working, Fixes: #7854#7899
Closed
utpalsavliya wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
…ms#7854 Corrected the split docstring to reflect the working of the function, i.e., elements equal to the split value will be contained by left subtree, which before correction the docstring stated to be contained in the right subtree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the split docstring to reflect the working of the function, i.e., elements equal to the split value will be contained by left subtree, which before correction the docstring stated to be contained in the right subtree.
Describe your change:
Implemented the suggestion by @vbvg2008 for issue #7854 to correct the docstring. Didn't choose to modify the code as stated in the latter part of suggestion as I found couple of resources online which kept the elements equal to the key in left subtree, supporting the former part of the suggestion.
Links to resources -
https://cp-algorithms.com/data_structures/treap.html#implicit-treaps
https://medium.com/carpanese/a-visual-introduction-to-treap-data-structure-part-1-6196d6cc12ee
Checklist:
Fixes: #{$ISSUE_NO}.