Create sol1.py #7970
Create sol1.py #7970
Conversation
proposed solution : generate all primitive pythagorean triples and check if it satisfies constraints in problem statement
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
| import math | ||
|
|
||
| def solution(number: int = 1000000000) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_094/sol1.py, please provide doctest for the function solution
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
| import math | ||
|
|
||
| def solution(number: int = 1000000000) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_094/sol1.py, please provide doctest for the function solution
for more information, see https://pre-commit.ci
Click here to look at the relevant links ⬇️
🔗 Relevant LinksRepository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| import math | ||
|
|
||
|
|
||
| def solution(number: int = 1000000000) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_094/sol1.py, please provide doctest for the function solution
| total = 0 | ||
| for a in range(1, int(math.sqrt(number // 4))): | ||
| for b in range(1, a): | ||
| # generate all primitive pythagorean triples and check if it satisfies constraints |
There was a problem hiding this comment.
project_euler/problem_094/sol1.py:18:89: E501 line too long (94 > 88 characters)
proposed solution : generate all primitive pythagorean triples and check if it satisfies constraints in problem statement
Describe your change: