Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] struct: update note about network byte order form to be more helpful #22201

Merged
merged 1 commit into from Sep 11, 2020

Conversation

theacodes
Copy link
Contributor

@theacodes theacodes commented Sep 11, 2020

Update the sentence to provide some context on why network byte order is defined as big endian.

Automerge-Triggered-By: @Mariatta

@theacodes
Copy link
Contributor Author

theacodes commented Sep 11, 2020

re: issue number and news, this is a trivial change and shouldn't require these - but let me know if you feel otherwise and I'm happy to do so.

Copy link
Sponsor Member

@Mariatta Mariatta left a comment

Thanks!

@Mariatta Mariatta added needs backport to 3.8 needs backport to 3.9 skip issue skip news 🤖 automerge PR will be merged once it's been approved and all CI passed labels Sep 11, 2020
@miss-islington miss-islington merged commit fb27187 into python:master Sep 11, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2020

Thanks @theacodes for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@theacodes theacodes deleted the fix-struct-network-order branch Sep 11, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2020
…lpful (pythonGH-22201)

Update the sentence to provide some context on why network byte order is defined as big endian.
(cherry picked from commit fb27187)

Co-authored-by: Stargirl Flowers <theaflowers@google.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2020

GH-22202 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2020
…lpful (pythonGH-22201)

Update the sentence to provide some context on why network byte order is defined as big endian.
(cherry picked from commit fb27187)

Co-authored-by: Stargirl Flowers <theaflowers@google.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2020

GH-22203 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 11, 2020
…lpful (GH-22201)

Update the sentence to provide some context on why network byte order is defined as big endian.
(cherry picked from commit fb27187)

Co-authored-by: Stargirl Flowers <theaflowers@google.com>
miss-islington added a commit that referenced this pull request Sep 11, 2020
…lpful (GH-22201)

Update the sentence to provide some context on why network byte order is defined as big endian.
(cherry picked from commit fb27187)

Co-authored-by: Stargirl Flowers <theaflowers@google.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
…lpful (pythonGH-22201)

Update the sentence to provide some context on why network byte order is defined as big endian.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants