Skip to content

Add dataclass field default change to 3.11 what's new#96790

Merged
gvanrossum merged 6 commits intopython:mainfrom
EpicWink:patch-1
Sep 13, 2022
Merged

Add dataclass field default change to 3.11 what's new#96790
gvanrossum merged 6 commits intopython:mainfrom
EpicWink:patch-1

Conversation

@EpicWink
Copy link
Copy Markdown
Contributor

Include dataclass field default mutability check change introduced in #29867. See discourse discussion

Include dataclass field default mutability check change introduced in python#29867. See [discourse discussion](https://discuss.python.org/t/better-communicate-dataclass-mutable-default-check-change-in-python-3-11)
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 13, 2022
@EpicWink EpicWink changed the title Add dataclass field default change Add dataclass field default change to 3.11 what's new Sep 13, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk
Copy link
Copy Markdown
Member

hugovk commented Sep 13, 2022

@ericsnowcurrently How does this look as a What's New for #29867?

@AlexWaygood
Copy link
Copy Markdown
Member

@ericsnowcurrently How does this look as a What's New for #29867?

I think you got the wrong Eric — you want @ericvsmith!

Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablogsal What is your position on doc changes post rc2? Especially the what's new would be nice to be up to date.

@gvanrossum gvanrossum merged commit 4995f5f into python:main Sep 13, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @EpicWink for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link
Copy Markdown

GH-96802 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 13, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
(cherry picked from commit 4995f5f)

Co-authored-by: Laurie O <laurie_opperman@hotmail.com>
miss-islington added a commit that referenced this pull request Sep 13, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
(cherry picked from commit 4995f5f)

Co-authored-by: Laurie O <laurie_opperman@hotmail.com>
@EpicWink EpicWink deleted the patch-1 branch September 22, 2022 07:11
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
(cherry picked from commit 4995f5f)

Co-authored-by: Laurie O <laurie_opperman@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants